Update release.yml

- Improve loading time (parallelize version detection)
- Newest asset upload date as release date for GitHub (#1284)
- Enable 'start on boot' for BG task (#1234)
- Remove the need to hardcode Obtainium's version number

.github/workflows/release.yml

@@ -2,6 +2,10 @@ name: Build and Release
 
 on:
   workflow_dispatch:
+    inputs:
+      beta:
+        type: boolean
+        description: Is beta?
     
 jobs:
   build:
@@ -19,6 +23,17 @@ jobs:
           gpg_private_key: ${{ secrets.PGP_KEY_BASE64 }}
           passphrase: ${{ secrets.PGP_PASSPHRASE }}
 
+      - name: Extract Version
+        id: extract_version      
+        run: |
+           VERSION=$(grep -oP "^version: [^\+]+" pubspec.yaml | tail -c +10)
+           echo "version=$VERSION" >> $GITHUB_OUTPUT
+           if [ ${{ inputs.beta }} == true ]; then BETA=true; else BETA=false; fi
+           echo "beta=$BETA" >> $GITHUB_OUTPUT
+           TAG="v$VERSION"
+           if [ $BETA == true ]; then TAG="$TAG"-beta; fi
+           echo "tag=$TAG" >> $GITHUB_OUTPUT
+
       - name: Build APKs
         run: |
           sed -i 's/signingConfig signingConfigs.release//g' android/app/build.gradle
@@ -43,16 +58,6 @@ jobs:
           done
           rm apksign.keystore
           PGP_KEY_FINGERPRINT="${{ steps.import_pgp_key.outputs.fingerprint }}"
-        
-      - name: Extract Version
-        id: extract_version      
-        run: |
-           VERSION=$(grep -oP "currentVersion = '\K[^']+" lib/main.dart)
-           echo "version=$VERSION" >> $GITHUB_OUTPUT
-           TAG=$(grep -oP "'.*\\\$currentVersion.*'" lib/main.dart | head -c -2 | tail -c +2 | sed "s/\$currentVersion/$VERSION/g")
-           echo "tag=$TAG" >> $GITHUB_OUTPUT
-           if [ -n "$(echo $TAG | grep -oP '\-beta$')" ]; then BETA=true; else BETA=false; fi
-           echo "beta=$BETA" >> $GITHUB_OUTPUT
 
       - name: Create Tag
         uses: mathieudutour/github-tag-action@v6.1

assets/translations/bs.json

@@ -291,6 +291,7 @@
     "shizukuBinderNotFound": "Shizuku is not running",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "Želite li ukloniti aplikaciju?",
         "other": "Želite li ukloniti aplikacije?"

assets/translations/cs.json

@@ -291,6 +291,7 @@
     "shizukuBinderNotFound": "Shizuku neběží",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "Odstranit Apku?",
         "other": "Odstranit Apky?"

assets/translations/de.json

@@ -291,6 +291,7 @@
     "shizukuBinderNotFound": "Shizuku läuft nicht",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "App entfernen?",
         "other": "Apps entfernen?"

assets/translations/en.json

@@ -293,6 +293,7 @@
     "systemFontError": "Error loading the system font: {}",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "Remove App?",
         "other": "Remove Apps?"

assets/translations/es.json

@@ -291,6 +291,7 @@
     "shizukuBinderNotFound": "Shizuku no está operativo",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "¿Eliminar Aplicación?",
         "other": "¿Eliminar Aplicaciones?"

assets/translations/fa.json

@@ -291,6 +291,7 @@
     "shizukuBinderNotFound": "Shizuku در حال اجرا نیست",
     "useVersionCodeAsOSVersion": "استفاده کد نسخه برنامه به جای نسخه شناسایی شده توسط سیستم عامل استفاده کنید",
     "requestHeader": "درخواست سطر بالایی",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "برنامه حذف شود؟",
         "other": "برنامه ها حذف شوند؟"

assets/translations/fr.json

@@ -291,6 +291,7 @@
     "shizukuBinderNotFound": "Shizuku is not running",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "Supprimer l'application ?",
         "other": "Supprimer les applications ?"

assets/translations/hu.json

@@ -291,6 +291,7 @@
     "shizukuBinderNotFound": "A Shizuku nem fut",
     "useVersionCodeAsOSVersion": "Az app versionCode használata a rendszer által észlelt verzióként",
     "requestHeader": "Kérelem fejléc",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "Eltávolítja az alkalmazást?",
         "other": "Eltávolítja az alkalmazást?"

assets/translations/it.json

@@ -291,6 +291,7 @@
     "shizukuBinderNotFound": "Shizuku non è in esecuzione",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "Rimuovere l'app?",
         "other": "Rimuovere le app?"

assets/translations/ja.json

@@ -293,6 +293,7 @@
     "systemFontError": "システムフォントの読み込みエラー: {}",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "アプリを削除しますか？",
         "other": "アプリを削除しますか？"

assets/translations/nl.json

@@ -291,6 +291,7 @@
     "shizukuBinderNotFound": "Shizuku is not running",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "App verwijderen?",
         "other": "Apps verwijderen?"

assets/translations/pl.json

@@ -291,6 +291,7 @@
     "shizukuBinderNotFound": "Shizuku is not running",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "Usunąć aplikację?",
         "few": "Usunąć aplikacje?",

assets/translations/pt.json

@@ -291,6 +291,7 @@
     "shizukuBinderNotFound": "Shizuku não está rodando",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "Remover aplicativo?",
         "other": "Remover aplicativos?"

assets/translations/ru.json

@@ -293,6 +293,7 @@
     "systemFontError": "Ошибка загрузки системного шрифта: {}",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "Удалить приложение?",
         "other": "Удалить приложения?"

assets/translations/sv.json

@@ -277,6 +277,7 @@
     "shizukuBinderNotFound": "Shizuku is not running",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "Ta Bort App?",
         "other": "Ta Bort Appar?"

assets/translations/tr.json

@@ -291,6 +291,7 @@
     "shizukuBinderNotFound": "Shizuku is not running",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "Uygulamayı Kaldır?",
         "other": "Uygulamaları Kaldır?"

assets/translations/vi.json

@@ -289,6 +289,7 @@
     "shizuku": "Shizuku",
     "root": "Root",
     "shizukuBinderNotFound": "Shizuku chưa khởi động",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion":{
         "one": "Gỡ ứng dụng?",
         "other": "Gỡ ứng dụng?"

assets/translations/zh.json

@@ -293,6 +293,7 @@
     "systemFontError": "加载系统字体出错：{}",
     "useVersionCodeAsOSVersion": "Use app versionCode as OS-detected version",
     "requestHeader": "Request header",
+    "useLatestAssetDateAsReleaseDate": "Use latest asset upload as release date",
     "removeAppQuestion": {
         "one": "是否删除应用？",
         "other": "是否删除应用？"

lib/app_sources/github.dart

@@ -76,6 +76,10 @@ class GitHub extends AppSource {
       [
         GeneratedFormSwitch('dontSortReleasesList',
             label: tr('dontSortReleasesList'))
+      ],
+      [
+        GeneratedFormSwitch('useLatestAssetDateAsReleaseDate',
+            label: tr('useLatestAssetDateAsReleaseDate'), defaultValue: false)
       ]
     ];
 
@@ -237,6 +241,8 @@ class GitHub extends AppSource {
     bool verifyLatestTag = additionalSettings['verifyLatestTag'] == true;
     bool dontSortReleasesList =
         additionalSettings['dontSortReleasesList'] == true;
+    bool useLatestAssetDateAsReleaseDate =
+        additionalSettings['useLatestAssetDateAsReleaseDate'] == true;
     dynamic latestRelease;
     if (verifyLatestTag) {
       var temp = requestUrl.split('?');
@@ -277,10 +283,31 @@ class GitHub extends AppSource {
               .toList() ??
           [];
 
-      DateTime? getReleaseDateFromRelease(dynamic rel) =>
+      DateTime? getPublishDateFromRelease(dynamic rel) =>
           rel?['published_at'] != null
               ? DateTime.parse(rel['published_at'])
               : null;
+      DateTime? getNewestAssetDateFromRelease(dynamic rel) {
+        var t = (rel['assets'] as List<dynamic>?)
+            ?.map((e) {
+              return e?['updated_at'] != null
+                  ? DateTime.parse(e['updated_at'])
+                  : null;
+            })
+            .where((e) => e != null)
+            .toList();
+        t?.sort((a, b) => b!.compareTo(a!));
+        if (t?.isNotEmpty == true) {
+          return t!.first;
+        }
+        return null;
+      }
+
+      DateTime? getReleaseDateFromRelease(dynamic rel, bool useAssetDate) =>
+          !useAssetDate
+              ? getPublishDateFromRelease(rel)
+              : getNewestAssetDateFromRelease(rel);
+
       if (dontSortReleasesList) {
         releases = releases.reversed.toList();
       } else {
@@ -305,8 +332,12 @@ class GitHub extends AppSource {
                   (nameA as String).substring(matchA!.start, matchA.end),
                   (nameB as String).substring(matchB!.start, matchB.end));
             } else {
-              return (getReleaseDateFromRelease(a) ?? DateTime(1))
-                  .compareTo(getReleaseDateFromRelease(b) ?? DateTime(0));
+              return (getReleaseDateFromRelease(
+                          a, useLatestAssetDateAsReleaseDate) ??
+                      DateTime(1))
+                  .compareTo(getReleaseDateFromRelease(
+                          b, useLatestAssetDateAsReleaseDate) ??
+                      DateTime(0));
             }
           }
         });
@@ -366,7 +397,8 @@ class GitHub extends AppSource {
         throw NoReleasesError();
       }
       String? version = targetRelease['tag_name'] ?? targetRelease['name'];
-      DateTime? releaseDate = getReleaseDateFromRelease(targetRelease);
+      DateTime? releaseDate = getReleaseDateFromRelease(
+          targetRelease, useLatestAssetDateAsReleaseDate);
       if (version == null) {
         throw NoVersionError();
       }

lib/main.dart

@@ -7,6 +7,7 @@ import 'package:obtainium/providers/apps_provider.dart';
 import 'package:obtainium/providers/logs_provider.dart';
 import 'package:obtainium/providers/notifications_provider.dart';
 import 'package:obtainium/providers/settings_provider.dart';
+import 'package:obtainium/providers/source_provider.dart';
 import 'package:permission_handler/permission_handler.dart';
 import 'package:provider/provider.dart';
 import 'package:dynamic_color/dynamic_color.dart';
@@ -18,10 +19,6 @@ import 'package:easy_localization/src/easy_localization_controller.dart';
 // ignore: implementation_imports
 import 'package:easy_localization/src/localization.dart';
 
-const String currentVersion = '0.15.10';
-const String currentReleaseTag =
-    'v$currentVersion-beta'; // KEEP THIS IN SYNC WITH GITHUB RELEASES
-
 List<MapEntry<Locale, String>> supportedLocales = const [
   MapEntry(Locale('en'), 'English'),
   MapEntry(Locale('zh'), '简体中文'),
@@ -143,6 +140,7 @@ class _ObtainiumState extends State<Obtainium> {
         BackgroundFetchConfig(
             minimumFetchInterval: 15,
             stopOnTerminate: false,
+            startOnBoot: true,
             enableHeadless: true,
             requiresBatteryNotLow: false,
             requiresCharging: false,
@@ -173,7 +171,29 @@ class _ObtainiumState extends State<Obtainium> {
         // If this is the first run, ask for notification permissions and add Obtainium to the Apps list
         Permission.notification.request();
         if (!fdroid) {
-          appsProvider.saveApps([obtainiumApp], onlyIfExists: false);
+          getInstalledInfo(obtainiumId).then((value) {
+            if (value?.versionName != null) {
+              appsProvider.saveApps([
+                App(
+                    obtainiumId,
+                    obtainiumUrl,
+                    'ImranR98',
+                    'Obtainium',
+                    value!.versionName,
+                    value.versionName!,
+                    [],
+                    0,
+                    {
+                      'includePrereleases': true,
+                      'versionDetection': 'standardVersionDetection'
+                    },
+                    null,
+                    false)
+              ], onlyIfExists: false);
+            }
+          }).catchError((err) {
+            print(err);
+          });
         }
       }
       if (!supportedLocales

lib/pages/apps.dart

@@ -904,7 +904,7 @@ class AppsPageState extends State<AppsPage> {
                                       }))}">${a.name}</a></li>\n';
                                 }
                                 urls +=
-                                    '</ul>\n\n<p><a href="${obtainiumApp.url}">${tr('about')}</a></p>';
+                                    '</ul>\n\n<p><a href="$obtainiumUrl">${tr('about')}</a></p>';
                                 Share.share(urls,
                                     subject:
                                         '${tr('obtainium')} - ${tr('appsString')}');

lib/providers/apps_provider.dart

@@ -234,6 +234,20 @@ Future<File> downloadFile(
   return downloadedFile;
 }
 
+Future<PackageInfo?> getInstalledInfo(String? packageName,
+    {bool printErr = true}) async {
+  if (packageName != null) {
+    try {
+      return await pm.getPackageInfo(packageName: packageName);
+    } catch (e) {
+      if (printErr) {
+        print(e); // OK
+      }
+    }
+  }
+  return null;
+}
+
 class AppsProvider with ChangeNotifier {
   // In memory App state (should always be kept in sync with local storage versions)
   Map<String, AppInMemory> apps = {};
@@ -404,7 +418,7 @@ class AppsProvider with ChangeNotifier {
       .isNotEmpty;
 
   Future<bool> canInstallSilently(App app) async {
-    if (app.id == obtainiumApp.id) {
+    if (app.id == obtainiumId) {
       return false;
     }
     if (!settingsProvider.enableBackgroundUpdates) {
@@ -428,7 +442,7 @@ class AppsProvider with ChangeNotifier {
     } catch (e) {
       // Probably not installed - ignore
     }
-    if (installerPackageName != obtainiumApp.id) {
+    if (installerPackageName != obtainiumId) {
       // If we did not install the app (or it isn't installed), silent install is not possible
       return false;
     }
@@ -639,6 +653,7 @@ class AppsProvider with ChangeNotifier {
       MapEntry<String, String>? apkUrl;
       var trackOnly = apps[id]!.app.additionalSettings['trackOnly'] == true;
       if (!trackOnly) {
+        // ignore: use_build_context_synchronously
         apkUrl = await confirmApkUrl(apps[id]!.app, context);
       }
       if (apkUrl != null) {
@@ -673,7 +688,7 @@ class AppsProvider with ChangeNotifier {
 
     // Move Obtainium to the end of the line (let all other apps update first)
     appsToInstall =
-        moveStrToEnd(appsToInstall, obtainiumApp.id, strB: obtainiumTempId);
+        moveStrToEnd(appsToInstall, obtainiumId, strB: obtainiumTempId);
 
     Future<void> updateFn(String id, {bool skipInstalls = false}) async {
       try {
@@ -775,20 +790,6 @@ class AppsProvider with ChangeNotifier {
     return appsDir;
   }
 
-  Future<PackageInfo?> getInstalledInfo(String? packageName,
-      {bool printErr = true}) async {
-    if (packageName != null) {
-      try {
-        return await pm.getPackageInfo(packageName: packageName);
-      } catch (e) {
-        if (printErr) {
-          print(e); // OK
-        }
-      }
-    }
-    return null;
-  }
-
   bool isVersionDetectionPossible(AppInMemory? app) {
     if (app?.app == null) {
       return false;
@@ -917,6 +918,17 @@ class AppsProvider with ChangeNotifier {
         : false;
   }
 
+  Future<void> updateInstallStatusInMemory(AppInMemory app) async {
+    apps[app.app.id]?.installedInfo = await getInstalledInfo(app.app.id);
+    apps[app.app.id]?.icon =
+        await apps[app.app.id]?.installedInfo?.applicationInfo?.getAppIcon();
+    apps[app.app.id]?.app.name = await (apps[app.app.id]
+            ?.installedInfo
+            ?.applicationInfo
+            ?.getAppLabel()) ??
+        app.name;
+  }
+
   Future<void> loadApps({String? singleId}) async {
     while (loadingApps) {
       await Future.delayed(const Duration(microseconds: 1));
@@ -965,19 +977,11 @@ class AppsProvider with ChangeNotifier {
       NotificationsProvider().notify(
           AppsRemovedNotification(errors.map((e) => [e[1], e[2]]).toList()));
     }
-
-    for (var app in apps.values) {
-      // Get install status and other OS info for each App (slow)
-      apps[app.app.id]?.installedInfo = await getInstalledInfo(app.app.id);
-      apps[app.app.id]?.icon =
-          await apps[app.app.id]?.installedInfo?.applicationInfo?.getAppIcon();
-      apps[app.app.id]?.app.name = await (apps[app.app.id]
-              ?.installedInfo
-              ?.applicationInfo
-              ?.getAppLabel()) ??
-          app.name;
-      notifyListeners();
-    }
+    // Get install status and other OS info for each App (slow)
+    await Future.wait(apps.values.map((app) {
+      return updateInstallStatusInMemory(app);
+    }));
+    notifyListeners();
     // Reconcile version differences
     List<App> modifiedApps = [];
     for (var app in apps.values) {
@@ -1000,7 +1004,6 @@ class AppsProvider with ChangeNotifier {
         }
       }
     }
-
     loadingApps = false;
     notifyListeners();
   }
@@ -1676,8 +1679,7 @@ Future<void> bgUpdateCheck(String taskId, Map<String, dynamic>? params) async {
     }
     if (toInstall.isNotEmpty) {
       logs.add('BG install task: Started (${toInstall.length}).');
-      var tempObtArr =
-          toInstall.where((element) => element.key == obtainiumApp.id);
+      var tempObtArr = toInstall.where((element) => element.key == obtainiumId);
       if (tempObtArr.isNotEmpty) {
         // Move obtainium to the end of the list as it must always install last
         var obt = tempObtArr.first;

lib/providers/settings_provider.dart

@@ -15,22 +15,8 @@ import 'package:shared_preferences/shared_preferences.dart';
 import 'package:shared_storage/shared_storage.dart' as saf;
 
 String obtainiumTempId = 'imranr98_obtainium_${GitHub().hosts[0]}';
-
-App obtainiumApp = App(
-    'dev.imranr.obtainium',
-    'https://github.com/ImranR98/Obtainium',
-    'ImranR98',
-    'Obtainium',
-    currentReleaseTag,
-    currentReleaseTag,
-    [],
-    0,
-    {
-      'includePrereleases': true,
-      'versionDetection': 'standardVersionDetection'
-    },
-    null,
-    false);
+String obtainiumId = 'dev.imranr.obtainium';
+String obtainiumUrl = 'https://github.com/ImranR98/Obtainium';
 
 enum InstallMethodSettings { normal, shizuku, root }
 

pubspec.yaml

@@ -17,7 +17,7 @@ publish_to: 'none' # Remove this line if you wish to publish to pub.dev
 # https://developer.apple.com/library/archive/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html
 # In Windows, build-name is used as the major, minor, and patch parts
 # of the product and file versions while build-number is used as the build suffix.
-version: 0.15.10+246 # When changing this, update the tag in main() accordingly
+version: 0.15.11+247 # When changing this, update the tag in main() accordingly
 
 environment:
   sdk: '>=3.0.0 <4.0.0'