peter/Obtainium
1
0
Fork 0
mirror of https://github.com/ImranR98/Obtainium.git synced 2025-07-23 01:29:40 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixed code smells

Browse Source
This commit is contained in:
Imran Remtulla
2023-05-14 12:29:37 -04:00
parent f80c9ec33e
commit d212f13345
13 changed files with 8 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/app_sources/apkcombo.dart
View File

@@ -1,6 +1,5 @@
import 'package:easy_localization/easy_localization.dart';
import 'package:html/parser.dart';
import 'package:http/http.dart';
import 'package:obtainium/custom_errors.dart';
import 'package:obtainium/providers/source_provider.dart';
@@ -85,7 +84,6 @@ class APKCombo extends AppSource {
Map<String, dynamic> additionalSettings,
) async {
String appId = tryInferringAppId(standardUrl)!;
String host = Uri.parse(standardUrl).host;
var preres = await sourceRequest(standardUrl);
if (preres.statusCode != 200) {
throw getObtainiumHttpError(preres);

1
lib/app_sources/apkpure.dart
View File

@@ -1,6 +1,5 @@
import 'package:easy_localization/easy_localization.dart';
import 'package:html/parser.dart';
import 'package:http/http.dart';
import 'package:obtainium/custom_errors.dart';
import 'package:obtainium/providers/source_provider.dart';

2
lib/app_sources/codeberg.dart
View File

@@ -1,6 +1,4 @@
import 'dart:convert';
import 'package:easy_localization/easy_localization.dart';
import 'package:http/http.dart';
import 'package:obtainium/app_sources/github.dart';
import 'package:obtainium/components/generated_form.dart';
import 'package:obtainium/custom_errors.dart';

1
lib/app_sources/fdroidrepo.dart
View File

@@ -1,6 +1,5 @@
import 'package:easy_localization/easy_localization.dart';
import 'package:html/parser.dart';
import 'package:http/http.dart';
import 'package:obtainium/components/generated_form.dart';
import 'package:obtainium/custom_errors.dart';
import 'package:obtainium/providers/source_provider.dart';

4
lib/app_sources/gitlab.dart
View File

@@ -83,12 +83,12 @@ class GitLab extends AppSource {
}
var json = jsonDecode(res.body) as List<dynamic>;
Map<String, List<String>> results = {};
json.forEach((element) {
for (var element in json) {
results['https://$host/${element['path_with_namespace']}'] = [
element['name_with_namespace'],
element['description'] ?? tr('noDescription')
];
});
}
return results;
}

1
lib/app_sources/izzyondroid.dart
View File

@@ -1,4 +1,3 @@
import 'package:http/http.dart';
import 'package:obtainium/app_sources/fdroid.dart';
import 'package:obtainium/custom_errors.dart';
import 'package:obtainium/providers/source_provider.dart';

1
lib/app_sources/jenkins.dart
View File

@@ -10,7 +10,6 @@ class Jenkins extends AppSource {
overrideVersionDetectionFormDefault('releaseDateAsVersion', true);
}
@override
String trimJobUrl(String url) {
RegExp standardUrlRegEx = RegExp('.*/job/[^/]+');
RegExpMatch? match = standardUrlRegEx.firstMatch(url);

2
lib/app_sources/sourcehut.dart
View File

@@ -1,6 +1,5 @@
import 'package:html/parser.dart';
import 'package:http/http.dart';
import 'package:obtainium/app_sources/github.dart';
import 'package:obtainium/app_sources/html.dart';
import 'package:obtainium/custom_errors.dart';
import 'package:obtainium/providers/source_provider.dart';
@@ -58,7 +57,6 @@ class SourceHut extends AppSource {
throw NoVersionError();
}
String? releaseDateString = entry.querySelector('pubDate')?.innerHtml;
var link = entry.querySelector('link');
String releasePage = '$standardUrl/refs/$version';
DateTime? releaseDate = releaseDateString != null
? DateFormat('EEE, dd MMM yyyy HH:mm:ss Z').parse(releaseDateString)

1
lib/app_sources/vlc.dart
View File

@@ -1,6 +1,5 @@
import 'package:html/parser.dart';
import 'package:http/http.dart';
import 'package:obtainium/app_sources/html.dart';
import 'package:obtainium/custom_errors.dart';
import 'package:obtainium/providers/source_provider.dart';

1
lib/pages/app.dart
View File

@@ -32,6 +32,7 @@ class _AppPageState extends State<AppPage> {
getUpdate(String id) {
appsProvider.checkUpdate(id).catchError((e) {
showError(e, context);
return null;
});
}

3
lib/pages/apps.dart
View File

@@ -71,6 +71,7 @@ class AppsPageState extends State<AppsPage> {
});
return appsProvider.checkUpdates().catchError((e) {
showError(e, context);
return <App>[];
}).whenComplete(() {
setState(() {
refreshingSince = null;
@@ -379,6 +380,7 @@ class AppsPageState extends State<AppsPage> {
[listedApps[appIndex].app.id],
globalNavigatorKey.currentContext).catchError((e) {
showError(e, context);
return <String>[];
});
},
icon: Icon(
@@ -681,6 +683,7 @@ class AppsPageState extends State<AppsPage> {
settingsProvider: settingsProvider)
.catchError((e) {
showError(e, context);
return <String>[];
});
}
});

4
lib/pages/import_export.dart
View File

@@ -323,8 +323,8 @@ class _ImportExportPageState extends State<ImportExportPage> {
],
),
if (importInProgress)
Column(
children: const [
const Column(
children: [
SizedBox(
height: 14,
),

1
lib/providers/source_provider.dart
View File

@@ -7,7 +7,6 @@ import 'package:device_info_plus/device_info_plus.dart';
import 'package:easy_localization/easy_localization.dart';
import 'package:html/dom.dart';
import 'package:http/http.dart';
import 'package:obtainium/app_sources/apkcombo.dart';
import 'package:obtainium/app_sources/apkmirror.dart';
import 'package:obtainium/app_sources/apkpure.dart';
import 'package:obtainium/app_sources/codeberg.dart';