From 7f4cf6e6811c5a41c995377d1165ca2fd2a750f0 Mon Sep 17 00:00:00 2001 From: Imran Remtulla Date: Tue, 5 Mar 2024 10:37:36 -0500 Subject: [PATCH 1/2] Fix bug in GitHub's 'verify latest' option (#1449) --- lib/app_sources/github.dart | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/app_sources/github.dart b/lib/app_sources/github.dart index 251a118..96cd8b3 100644 --- a/lib/app_sources/github.dart +++ b/lib/app_sources/github.dart @@ -343,13 +343,14 @@ class GitHub extends AppSource { } }); } - if (latestRelease != null && + if ((latestRelease['tag_name'] ?? latestRelease['name']) != null && releases.isNotEmpty && latestRelease != (releases[releases.length - 1]['tag_name'] ?? releases[0]['name'])) { var ind = releases.indexWhere((element) => - latestRelease == (element['tag_name'] ?? element['name'])); + (latestRelease['tag_name'] ?? latestRelease['name']) == + (element['tag_name'] ?? element['name'])); if (ind >= 0) { releases.add(releases.removeAt(ind)); } From e7c2112f417c3f079d6ad5782cf7c8ff3f9bbb4e Mon Sep 17 00:00:00 2001 From: Imran Remtulla Date: Sat, 9 Mar 2024 13:50:22 -0500 Subject: [PATCH 2/2] Bugfix from prev. commit --- lib/app_sources/github.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/app_sources/github.dart b/lib/app_sources/github.dart index 96cd8b3..f6e2615 100644 --- a/lib/app_sources/github.dart +++ b/lib/app_sources/github.dart @@ -343,7 +343,8 @@ class GitHub extends AppSource { } }); } - if ((latestRelease['tag_name'] ?? latestRelease['name']) != null && + if (latestRelease != null && + (latestRelease['tag_name'] ?? latestRelease['name']) != null && releases.isNotEmpty && latestRelease != (releases[releases.length - 1]['tag_name'] ??