From 2a58ee87293b1a7f971501d6f286ecf383e85831 Mon Sep 17 00:00:00 2001 From: Imran Remtulla Date: Fri, 14 Jul 2023 21:53:50 -0400 Subject: [PATCH] Toggle to disable update check on detail page (#659), string capitalization consistency --- assets/translations/de.json | 1 + assets/translations/en.json | 15 ++++++++------- assets/translations/es.json | 5 +++-- assets/translations/fa.json | 1 + assets/translations/fr.json | 9 +++++---- assets/translations/hu.json | 1 + assets/translations/it.json | 1 + assets/translations/ja.json | 3 ++- assets/translations/pl.json | 1 + assets/translations/ru.json | 1 + assets/translations/zh.json | 1 + lib/pages/app.dart | 5 ++++- lib/pages/settings.dart | 15 +++++++++++++++ lib/providers/settings_provider.dart | 9 +++++++++ 14 files changed, 53 insertions(+), 15 deletions(-) diff --git a/assets/translations/de.json b/assets/translations/de.json index 06c1337..0386135 100644 --- a/assets/translations/de.json +++ b/assets/translations/de.json @@ -236,6 +236,7 @@ "tryInferAppIdFromCode": "Try inferring App ID from source code", "removeOnExternalUninstall": "Automatically remove externally uninstalled Apps", "pickHighestVersionCode": "Auto-select highest version code APK", + "checkUpdateOnDetailPage": "Check for updates on opening an App detail page", "removeAppQuestion": { "one": "App entfernen?", "other": "Apps entfernen?" diff --git a/assets/translations/en.json b/assets/translations/en.json index e06e460..15e46dc 100644 --- a/assets/translations/en.json +++ b/assets/translations/en.json @@ -121,7 +121,7 @@ "followSystem": "Follow System", "obtainium": "Obtainium", "materialYou": "Material You", - "useBlackTheme": "Use Pure Black Dark Theme", + "useBlackTheme": "Use pure black dark theme", "appSortBy": "App Sort By", "authorName": "Author/Name", "nameAuthor": "Name/Author", @@ -132,8 +132,8 @@ "bgUpdateCheckInterval": "Background Update Checking Interval", "neverManualOnly": "Never - Manual Only", "appearance": "Appearance", - "showWebInAppView": "Show Source Webpage in App View", - "pinUpdates": "Pin Updates to Top of Apps View", + "showWebInAppView": "Show Source webpage in App view", + "pinUpdates": "Pin updates to top of Apps view", "updates": "Updates", "sourceSpecific": "Source-Specific", "appSource": "App Source", @@ -226,16 +226,17 @@ "autoApkFilterByArch": "Attempt to filter APKs by CPU architecture if possible", "overrideSource": "Override Source", "dontShowAgain": "Don't show this again", - "dontShowTrackOnlyWarnings": "Don't Show 'Track-Only' Warnings", - "dontShowAPKOriginWarnings": "Don't Show APK Origin Warnings", - "moveNonInstalledAppsToBottom": "Move Non-Installed Apps to Bottom of Apps View", + "dontShowTrackOnlyWarnings": "Don't show 'Track-Only' warnings", + "dontShowAPKOriginWarnings": "Don't show APK origin warnings", + "moveNonInstalledAppsToBottom": "Move non-installed Apps to bottom of Apps view", "gitlabPATLabel": "GitLab Personal Access Token (Enables Search)", "about": "About", "requiresCredentialsInSettings": "This needs additional credentials (in Settings)", - "checkOnStart": "Check Once on Start", + "checkOnStart": "Check for updates on startup", "tryInferAppIdFromCode": "Try inferring App ID from source code", "removeOnExternalUninstall": "Automatically remove externally uninstalled Apps", "pickHighestVersionCode": "Auto-select highest version code APK", + "checkUpdateOnDetailPage": "Check for updates on opening an App detail page", "removeAppQuestion": { "one": "Remove App?", "other": "Remove Apps?" diff --git a/assets/translations/es.json b/assets/translations/es.json index 4e53acc..1e557ab 100644 --- a/assets/translations/es.json +++ b/assets/translations/es.json @@ -228,14 +228,15 @@ "dontShowAgain": "No mostrar de nuevo", "dontShowTrackOnlyWarnings": "No mostrar avisos de 'Solo Seguimiento'", "dontShowAPKOriginWarnings": "No mostrar avisos de las fuentes de las APks", - "moveNonInstalledAppsToBottom": "Move Non-Installed Apps to Bottom of Apps View", + "moveNonInstalledAppsToBottom": "Move non-installed Apps to bottom of Apps view", "gitlabPATLabel": "GitLab Personal Access Token (Enables Search)", "about": "About", "requiresCredentialsInSettings": "This needs additional credentials (in Settings)", - "checkOnStart": "Check Once on Start", + "checkOnStart": "Check for updates on startup", "tryInferAppIdFromCode": "Try inferring App ID from source code", "removeOnExternalUninstall": "Automatically remove externally uninstalled Apps", "pickHighestVersionCode": "Auto-select highest version code APK", + "checkUpdateOnDetailPage": "Check for updates on opening an App detail page", "removeAppQuestion": { "one": "¿Eliminar Aplicación?", "other": "¿Eliminar Aplicaciones?" diff --git a/assets/translations/fa.json b/assets/translations/fa.json index 0f3c621..476b80a 100644 --- a/assets/translations/fa.json +++ b/assets/translations/fa.json @@ -236,6 +236,7 @@ "tryInferAppIdFromCode": "شناسه برنامه را از کد منبع استنباط کنید", "removeOnExternalUninstall": "Automatically remove externally uninstalled Apps", "pickHighestVersionCode": "Auto-select highest version code APK", + "checkUpdateOnDetailPage": "Check for updates on opening an App detail page", "removeAppQuestion": { "one": "برنامه حذف شود؟", "other": "برنامه ها حذف شوند؟" diff --git a/assets/translations/fr.json b/assets/translations/fr.json index 315f3d4..42a3c2d 100644 --- a/assets/translations/fr.json +++ b/assets/translations/fr.json @@ -121,7 +121,7 @@ "followSystem": "Suivre le système", "obtainium": "Obtainium", "materialYou": "Material You", - "useBlackTheme": "Use Pure Black Dark Theme", + "useBlackTheme": "Use pure black dark theme", "appSortBy": "Applications triées par", "authorName": "Auteur/Nom", "nameAuthor": "Nom/Auteur", @@ -227,15 +227,16 @@ "overrideSource": "Override Source", "dontShowAgain": "Don't show this again", "dontShowTrackOnlyWarnings": "Don't Show the 'Track-Only' Warning", - "dontShowAPKOriginWarnings": "Don't Show APK Origin Warnings", - "moveNonInstalledAppsToBottom": "Move Non-Installed Apps to Bottom of Apps View", + "dontShowAPKOriginWarnings": "Don't show APK origin warnings", + "moveNonInstalledAppsToBottom": "Move non-installed Apps to bottom of Apps view", "gitlabPATLabel": "GitLab Personal Access Token (Enables Search)", "about": "About", "requiresCredentialsInSettings": "This needs additional credentials (in Settings)", - "checkOnStart": "Check Once on Start", + "checkOnStart": "Check for updates on startup", "tryInferAppIdFromCode": "Try inferring App ID from source code", "removeOnExternalUninstall": "Automatically remove externally uninstalled Apps", "pickHighestVersionCode": "Auto-select highest version code APK", + "checkUpdateOnDetailPage": "Check for updates on opening an App detail page", "removeAppQuestion": { "one": "Supprimer l'application ?", "other": "Supprimer les applications ?" diff --git a/assets/translations/hu.json b/assets/translations/hu.json index 9927e40..787b05a 100644 --- a/assets/translations/hu.json +++ b/assets/translations/hu.json @@ -235,6 +235,7 @@ "tryInferAppIdFromCode": "Próbálja kikövetkeztetni az app azonosítót a forráskódból", "removeOnExternalUninstall": "Automatically remove externally uninstalled Apps", "pickHighestVersionCode": "Auto-select highest version code APK", + "checkUpdateOnDetailPage": "Check for updates on opening an App detail page", "removeAppQuestion": { "one": "Eltávolítja az alkalmazást?", "other": "Eltávolítja az alkalmazást?" diff --git a/assets/translations/it.json b/assets/translations/it.json index 6450895..1bed996 100644 --- a/assets/translations/it.json +++ b/assets/translations/it.json @@ -236,6 +236,7 @@ "tryInferAppIdFromCode": "Prova a dedurre l'ID dell'app dal codice sorgente", "removeOnExternalUninstall": "Automatically remove externally uninstalled Apps", "pickHighestVersionCode": "Auto-select highest version code APK", + "checkUpdateOnDetailPage": "Check for updates on opening an App detail page", "removeAppQuestion": { "one": "Rimuovere l'app?", "other": "Rimuovere le app?" diff --git a/assets/translations/ja.json b/assets/translations/ja.json index 00f4412..0892ecc 100644 --- a/assets/translations/ja.json +++ b/assets/translations/ja.json @@ -232,10 +232,11 @@ "gitlabPATLabel": "GitLab パーソナルアクセストークン (検索を有効化する)", "about": "概要", "requiresCredentialsInSettings": "これには追加の認証が必要です (設定にて)", - "checkOnStart": "Check Once on Start", + "checkOnStart": "Check for updates on startup", "tryInferAppIdFromCode": "Try inferring App ID from source code", "removeOnExternalUninstall": "Automatically remove externally uninstalled Apps", "pickHighestVersionCode": "Auto-select highest version code APK", + "checkUpdateOnDetailPage": "Check for updates on opening an App detail page", "removeAppQuestion": { "one": "アプリを削除しますか？", "other": "アプリを削除しますか？" diff --git a/assets/translations/pl.json b/assets/translations/pl.json index 0885008..241af7e 100644 --- a/assets/translations/pl.json +++ b/assets/translations/pl.json @@ -240,6 +240,7 @@ "tryInferAppIdFromCode": "Spróbuj wywnioskować identyfikator aplikacji z kodu źródłowego", "removeOnExternalUninstall": "Automatically remove externally uninstalled Apps", "pickHighestVersionCode": "Auto-select highest version code APK", + "checkUpdateOnDetailPage": "Check for updates on opening an App detail page", "removeAppQuestion": { "one": "Usunąć aplikację?", "other": "Usunąć aplikacje?" diff --git a/assets/translations/ru.json b/assets/translations/ru.json index 2e8da04..b20fedd 100644 --- a/assets/translations/ru.json +++ b/assets/translations/ru.json @@ -236,6 +236,7 @@ "tryInferAppIdFromCode": "Попытаться определить ID приложения из исходного кода", "removeOnExternalUninstall": "Automatically remove externally uninstalled Apps", "pickHighestVersionCode": "Auto-select highest version code APK", + "checkUpdateOnDetailPage": "Check for updates on opening an App detail page", "removeAppQuestion": { "one": "Удалить приложение?", "other": "Удалить приложения?" diff --git a/assets/translations/zh.json b/assets/translations/zh.json index 0439230..49da8bc 100644 --- a/assets/translations/zh.json +++ b/assets/translations/zh.json @@ -236,6 +236,7 @@ "tryInferAppIdFromCode": "尝试从源代码推断应用 ID", "removeOnExternalUninstall": "Automatically remove externally uninstalled Apps", "pickHighestVersionCode": "Auto-select highest version code APK", + "checkUpdateOnDetailPage": "Check for updates on opening an App detail page", "removeAppQuestion": { "one": "是否删除应用？", "other": "是否删除应用？" diff --git a/lib/pages/app.dart b/lib/pages/app.dart index 75aa675..2ba6a96 100644 --- a/lib/pages/app.dart +++ b/lib/pages/app.dart @@ -44,7 +44,10 @@ class _AppPageState extends State { ? sourceProvider.getSource(app.app.url, overrideSource: app.app.overrideSource) : null; - if (!areDownloadsRunning && prevApp == null && app != null) { + if (!areDownloadsRunning && + prevApp == null && + app != null && + settingsProvider.checkUpdateOnDetailPage) { prevApp = app; getUpdate(app.app.id); } diff --git a/lib/pages/settings.dart b/lib/pages/settings.dart index 7135a25..c63d2e8 100644 --- a/lib/pages/settings.dart +++ b/lib/pages/settings.dart @@ -240,6 +240,21 @@ class _SettingsPageState extends State { }) ], ), + height16, + Row( + mainAxisAlignment: MainAxisAlignment.spaceBetween, + children: [ + Flexible( + child: Text(tr('checkUpdateOnDetailPage'))), + Switch( + value: settingsProvider + .checkUpdateOnDetailPage, + onChanged: (value) { + settingsProvider.checkUpdateOnDetailPage = + value; + }) + ], + ), height32, Text( tr('sourceSpecific'), diff --git a/lib/providers/settings_provider.dart b/lib/providers/settings_provider.dart index 2319a6d..9fcfba0 100644 --- a/lib/providers/settings_provider.dart +++ b/lib/providers/settings_provider.dart @@ -282,4 +282,13 @@ class SettingsProvider with ChangeNotifier { prefs?.setBool('removeOnExternalUninstall', show); notifyListeners(); } + + bool get checkUpdateOnDetailPage { + return prefs?.getBool('checkUpdateOnDetailPage') ?? true; + } + + set checkUpdateOnDetailPage(bool show) { + prefs?.setBool('checkUpdateOnDetailPage', show); + notifyListeners(); + } }